Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
deankarn committed May 10, 2019
1 parent fcf0aa6 commit 1aa63b2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
3 changes: 1 addition & 2 deletions io/limit_reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@ var (
LimitedReaderEOF = errors.New("LimitedReader EOF: limit reached")
)

// LimitReader returns a Reader that reads from r
// LimitReader returns a LimitedReader that reads from r
// but stops with LimitedReaderEOF after n bytes.
// The underlying implementation is a *LimitedReader.
func LimitReader(r io.Reader, n int64) *LimitedReader {
return &LimitedReader{R: r, N: n}
}
Expand Down
10 changes: 5 additions & 5 deletions io/limit_reader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
)

func TestLimitedReader_Read(t *testing.T) {
eofLimited := LimitReader(strings.NewReader("all"), 5).(*LimitedReader)
eofLimited := LimitReader(strings.NewReader("all"), 5)

type args struct {
p []byte
Expand All @@ -20,14 +20,14 @@ func TestLimitedReader_Read(t *testing.T) {
}{
{
name: "not-limited",
l: LimitReader(strings.NewReader("all"), 3).(*LimitedReader),
l: LimitReader(strings.NewReader("all"), 3),
args: args{p: make([]byte, 4)},
wantN: 3,
wantErr: false,
},
{
name: "not-limited-exact",
l: LimitReader(strings.NewReader("all"), 3).(*LimitedReader),
l: LimitReader(strings.NewReader("all"), 3),
args: args{p: make([]byte, 3)},
wantN: 3,
wantErr: false,
Expand All @@ -48,14 +48,14 @@ func TestLimitedReader_Read(t *testing.T) {
},
{
name: "limited",
l: LimitReader(strings.NewReader("limited"), 1).(*LimitedReader),
l: LimitReader(strings.NewReader("limited"), 1),
args: args{p: make([]byte, 3)},
wantN: 2, // need to read one past to know we're past
wantErr: true,
},
{
name: "limited-buff-under-N",
l: LimitReader(strings.NewReader("limited"), 0).(*LimitedReader),
l: LimitReader(strings.NewReader("limited"), 0),
args: args{p: make([]byte, 1)},
wantN: 1,
wantErr: true,
Expand Down

0 comments on commit 1aa63b2

Please sign in to comment.