-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using sync.Pool #98
Comments
I will look into it, thanks! |
it helps with parallel benchmarks a bit and slightly increases the non parallel ones, but it's negligible. since this library is fully thread safe and I suspect will be used within a webserver or some other logic that will be parallelized this change will help with that. so going forward with the change. |
Awesome, here another advantage:
😄 |
True, ok v5.10 is now out, I had to drop support for go 1.2 for this change, but I think that's more than justified. |
@joeybloggs yes! I think it is ok to drop support for Go 1.2. |
This is just a suggestion: so instead of implementing your own pool:
https://github.com/bluesuncorp/validator/blob/v5/validator.go#L47-L52
it could be a good idea to use the built-in pool implementation of the sync package.
The text was updated successfully, but these errors were encountered: