Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unique= when struct field is a nil pointer #1041

Merged
merged 1 commit into from
Mar 19, 2023
Merged

fix unique= when struct field is a nil pointer #1041

merged 1 commit into from
Mar 19, 2023

Conversation

yansal
Copy link
Contributor

@yansal yansal commented Dec 14, 2022

Fix #749

Fixes Or Enhances

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@yansal yansal requested a review from a team as a code owner December 14, 2022 10:29
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 74.19% when pulling ad2157f on yansal:fix-unique-equals-when-struct-field-is-a-nil-pointer into c7e0172 on go-playground:master.

@yansal yansal mentioned this pull request Dec 14, 2022
Closed
deankarn
deankarn approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

will try and get this into next release

@deankarn deankarn merged commit cc768b1 into go-playground:master Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn deankarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unique tag panics if value is nil
3 participants
@yansal @coveralls @deankarn