Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State / Province codes not updated as in iso3166_2 standards #1087 #1088

Merged
merged 2 commits into from
Apr 29, 2023

Conversation

jozephp
Copy link
Contributor

@jozephp jozephp commented Mar 28, 2023

Fixes Or Enhances

Updated the state / province codes as per ISO website iso3166_2 standards

Make sure that you've checked the boxes below before you submit PR:

  • [X ] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

This is to cover the #1087

@jozephp jozephp requested a review from a team as a code owner March 28, 2023 10:44
@coveralls
Copy link

coveralls commented Mar 28, 2023

Coverage Status

Coverage: 73.88%. Remained the same when pulling fa2e135 on jozephp:issues_1087 into b7df869 on go-playground:master.

@jozephp
Copy link
Contributor Author

jozephp commented Mar 28, 2023

@deankarn can you please help review this ?

@jozephp
Copy link
Contributor Author

jozephp commented Apr 13, 2023

Could someone work to review this ?

@jozephp
Copy link
Contributor Author

jozephp commented Apr 24, 2023

@deankarn gentle reminder to approve and merge this PR

@deankarn
Copy link
Contributor

@jozephp thanks for the reminder, will try and look at this and other PRs within the next couple weeks. Benn busy with some other open source projects the last few weeks.

@deankarn deankarn merged commit 573fc80 into go-playground:master Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants