Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: excluded_* and required_* checks aren't triggered on pointers to structs #1124

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

iradmt
Copy link

@iradmt iradmt commented Jul 14, 2023

Fixes Or Enhances

Fix for #906
Trigger excluded_* and required_* checks on pointers to structs.
Before fix all default backed-in tags were ignored for non-nil pointers to structs.
Now it's possible to check whether pointer to struct is nil or not depending on another field value.

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@coveralls
Copy link

coveralls commented Jul 14, 2023

Coverage Status

coverage: 73.975% (+0.003%) from 73.972% when pulling 3453fec on iradmt:bugfix/nil_checkable_on_struct_ptr into bd1113d on go-playground:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants