Append new validations hostname and fqdn #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- hostname - fqdn
deankarn
requested changes
Aug 5, 2017
doc.go
Outdated
| @@ -794,6 +794,18 @@ Note: See Go's ParseMAC for accepted formats and types: | |||
|
|
|||
| http://golang.org/src/net/mac.go?s=866:918#L29 | |||
|
|
|||
| Hostname | |||
|
|
|||
| This validates that a stringa value is a valid Hostname | |||
There was a problem hiding this comment.
Just minor but if can change stringato string
deankarn
reviewed
Aug 5, 2017
regexes.go
Outdated
| @@ -30,6 +30,7 @@ const ( | |||
| latitudeRegexString = "^[-+]?([1-8]?\\d(\\.\\d+)?|90(\\.0+)?)$" | |||
| longitudeRegexString = "^[-+]?(180(\\.0+)?|((1[0-7]\\d)|([1-9]?\\d))(\\.\\d+)?)$" | |||
| sSNRegexString = `^\d{3}[- ]?\d{2}[- ]?\d{4}$` | |||
| hostnameRegexString = `^(([a-zA-Z]|[a-zA-Z][a-zA-Z0-9\-]*[a-zA-Z0-9])\.)*([A-Za-z]|[A-Za-z][A-Za-z0-9\-]*[A-Za-z0-9])$` | |||
There was a problem hiding this comment.
Also minor but if you could make the groups non-capturing that'd be great! eg. (?:
- Minor performance improve for FQDN validation - Fix typo in documentation - Simplified hostname regex
|
That validator is a great help and great work of you. |
deankarn
approved these changes
Aug 7, 2017
fairyhunter13
added a commit
to fairyhunter13/validator
that referenced
this pull request
Jul 12, 2020
Append new validations hostname and fqdn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances # .
Make sure that you've checked the boxes below before you submit PR:
Change Details:
added hostname & fqdn validations
@go-playground/admins
added hostname & fqdn validations