Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix StructLevel Parent() #716

Merged
merged 1 commit into from Apr 6, 2021
Merged

fix StructLevel Parent() #716

merged 1 commit into from Apr 6, 2021

Conversation

Torwang1
Copy link
Contributor

@Torwang1 Torwang1 commented Jan 6, 2021

Fixes Or Enhances

#715

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/admins

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.07% when pulling 62c9497 on Torwang1:master into f6584a4 on go-playground:master.

@Torwang1
Copy link
Contributor Author

Torwang1 commented Jan 7, 2021

Ping @deankarn
I was wondering if you could review this PR, thank you.

@deankarn
Copy link
Contributor

deankarn commented Jan 8, 2021

I will try to review this and others this week.

sorry for the delay, been very busy and frankly having trouble keeping up with it all.

deankarn
deankarn approved these changes Jan 9, 2021
View reviewed changes
Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm surprised this hasn't come up before, I will try to merge it this weekend.

@deankarn deankarn merged commit 882ec0d into go-playground:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn deankarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Torwang1 @coveralls @deankarn