Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removing the version from the go get ... command and import #765

Merged
merged 3 commits into from
Jul 26, 2021

Conversation

BrianLeishman
Copy link
Contributor

Fixes Or Enhances

fix #756

Undoes this pr? #710

Running go get github.com/go-playground/validator/v10 definitely seems to be the right command. Go getting without the version pulls 9 or just the master. Also importing without the version does not use the current version (v10 at the time of this pr)

Not applicable:
Make sure that you've checked the boxes below before you submit PR:
Tests exist or have been written that cover this particular change.

@go-playground/admins

BrianLeishman and others added 3 commits May 5, 2021 15:47
fix go-playground#756

Undoes this pr? go-playground#710

Running `go get github.com/go-playground/validator/v10` definitely seems to be the right command. Go getting without the version pulls 9 or just the master. Also importing without the version does not use the current version (v10 at the time of this pr)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.378% when pulling 657e636 on BrianLeishman:master into f1befad on go-playground:master.

@deankarn deankarn merged commit 8cfa1e9 into go-playground:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please up to date README.md
3 participants