Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add cve validator #983

Merged
merged 6 commits into from
Mar 19, 2023

Conversation

EduardoRMello
Copy link
Contributor

@EduardoRMello EduardoRMello commented Aug 4, 2022

Fixes Or Enhances

Add validator to Common Vulnerabilities and Exposures Identifier according to mitre.org

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@EduardoRMello EduardoRMello requested a review from a team as a code owner August 4, 2022 22:15
@coveralls
Copy link

coveralls commented Aug 4, 2022

Coverage Status

Coverage: 73.87% (+0.008%) from 73.862% when pulling 7f01ebf on EduardoRMello:feat/add-cve-validator into 58d420d on go-playground:master.

@EduardoRMello
Copy link
Contributor Author

Hello @deankarn ! Do you intend to maintain this repo ?

zemzale
zemzale previously approved these changes Oct 5, 2022
Copy link
Member

@zemzale zemzale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Has proper tests and seems to be in line with the spec.

@zemzale
Copy link
Member

zemzale commented Oct 5, 2022

@deankarn I don't have the right to merge/approve. Could you do it?

deankarn
deankarn previously approved these changes Mar 19, 2023
@deankarn deankarn dismissed stale reviews from zemzale and themself via 7f01ebf March 19, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants