Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position in commit notes no longer int64 #78

Closed
maguro opened this issue Jun 1, 2019 · 1 comment
Closed

Position in commit notes no longer int64 #78

maguro opened this issue Jun 1, 2019 · 1 comment

Comments

@maguro
Copy link
Contributor

maguro commented Jun 1, 2019

Position in commit notes are now an object. There are some additional position fields.

"change_position": {
    "base_sha": null,
    "start_sha": null,
    "head_sha": null,
    "old_path": null,
    "new_path": null,
    "position_type": "text",
    "old_line": null,
    "new_line": null
},
"original_position": {
    "base_sha": "068bca55a1606f8deda95713d043daae579123d0",
    "start_sha": "0883f2037428b19cac8bb5ac3823924dff0062e3",
    "head_sha": "130d7c3903d7d015219482fe5ad1b00110e76c4b",
    "old_path": "dataflow/src/main/java/com/nianticproject/lexicon/wb/transforms/ParseSessionTrackingProtos.java",
    "new_path": "dataflow/src/main/java/com/nianticproject/lexicon/wb/transforms/ParseSessionTrackingProtos.java",
    "position_type": "text",
    "old_line": null,
    "new_line": 50
},
"position": {
    "base_sha": "068bca55a1606f8deda95713d043daae579123d0",
    "start_sha": "0883f2037428b19cac8bb5ac3823924dff0062e3",
    "head_sha": "130d7c3903d7d015219482fe5ad1b00110e76c4b",
    "old_path": "dataflow/src/main/java/com/nianticproject/lexicon/wb/transforms/ParseSessionTrackingProtos.java",
    "new_path": "dataflow/src/main/java/com/nianticproject/lexicon/wb/transforms/ParseSessionTrackingProtos.java",
    "position_type": "text",
    "old_line": null,
    "new_line": 50
},
@deankarn
Copy link
Collaborator

merged PR in release v5.12.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants