Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go modules support #125

Merged
merged 2 commits into from Jan 14, 2021
Merged

Go modules support #125

merged 2 commits into from Jan 14, 2021

Conversation

Toshik1978
Copy link
Contributor

@deankarn concerning our discussion about go modules support. I've prepared this PR. What do you think?

  1. I've updated linter to the latest golangci-lint and added it to CI pipeline. To prevent future issues with bad linting.
  2. During linting I've found some old issues and fix them too. Now models looks more consistent. It's backward incompatible. But changes very-very simple for the users. And I think it's important to do it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.273% when pulling c99be7d on v6-go-modules into e6bb8aa on v6.

deankarn
deankarn approved these changes Jan 14, 2021
View reviewed changes
Copy link
Collaborator

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Work!!!

I think that after this is merged I might change to use GitHub Actions, but that's something that I can do later :)

@Toshik1978 Toshik1978 merged commit e5ab838 into v6 Jan 14, 2021
@Toshik1978 Toshik1978 deleted the v6-go-modules branch January 14, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn deankarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Toshik1978 @coveralls @deankarn