Simplify recently added context support #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The excellent idea of passing context when getting the connection by @bancek actually allows us to simplify (reverse) most of my original context support changes! Context only needs to be passed when creating the
Conn, so no need for a context argument on everyConnmember function.This PR simplifies context passing and also fixes nil-context errors when using the original non-context aware
MutexAPIs. There's no breaking changes (now that v4 is out there), it just simplifies the internals.I was going to try and get this pushed before #54 #55 #56 were merged but you beat me to it @hjr265. Better late than never!