Fix ExtendContext, and export until for client to check the validity of the acquired lock. #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose 2 changes.
Fix ExtendContext to check validity time and update
until
.As explained here, we need check validity time.
Add
Until()
to exportuntil
To export
until
is useful for client to check the validity of the acquired lock.Furthermore, I think there is a potential bug in current implementation of
ValidContext/Valid
. I'm going to create an issue about that soon.