fix test

mysql.go

@@ -56,6 +56,11 @@ func New(database *db.DB) rel.Adapter {
 
 // Open mysql connection using dsn.
 func Open(dsn string) (rel.Adapter, error) {
+	var database, err = db.Open("mysql", rewriteDsn(dsn))
+	return New(database), err
+}
+
+func rewriteDsn(dsn string) string {
 	// force clientFoundRows=true
 	// this allows not found record check when updating a record.
 	if strings.ContainsRune(dsn, '?') {
@@ -64,8 +69,7 @@ func Open(dsn string) (rel.Adapter, error) {
 		dsn += "?clientFoundRows=true"
 	}
 
-	var database, err = db.Open("mysql", dsn)
-	return New(database), err
+	return dsn
 }
 
 // MustOpen mysql connection using dsn.

mysql_test.go

@@ -125,25 +125,6 @@ func TestAdapter_PrimaryReplica_specs(t *testing.T) {
 	AdapterSpecs(t, repo)
 }
 
-func TestAdapter_Open(t *testing.T) {
-	dsn := "root@tcp(localhost:3306)"
-	if os.Getenv("MYSQL_DATABASE") != "" {
-		dsn = os.Getenv("MYSQL_DATABASE")
-	}
-
-	// with parameter
-	assert.NotPanics(t, func() {
-		adapter, _ := Open(dsn + "/rel_test?charset=utf8")
-		defer adapter.Close()
-	})
-
-	// without paremeter
-	assert.NotPanics(t, func() {
-		adapter, _ := Open(dsn + "/rel_test")
-		defer adapter.Close()
-	})
-}
-
 func TestAdapter_Transaction_commitError(t *testing.T) {
 	adapter, err := Open(dsn())
 	assert.Nil(t, err)
@@ -169,6 +150,14 @@ func TestAdapter_Exec_error(t *testing.T) {
 	assert.NotNil(t, err)
 }
 
+func TestRewriteDsn(t *testing.T) {
+	// with parameter
+	assert.Contains(t, rewriteDsn("root@tcp(localhost:3306)/rel_test?charset=utf8"), "&clientFoundRows=true")
+
+	// without paremeter
+	assert.Contains(t, rewriteDsn("root@tcp(localhost:3306)/rel_test"), "?clientFoundRows=true")
+}
+
 func TestCheck(t *testing.T) {
 	assert.Panics(t, func() {
 		check(errors.New("error"))