Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify timestamp format used by adapter #12

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Unify timestamp format used by adapter #12

merged 2 commits into from
Nov 5, 2021

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Nov 4, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 4, 2021 •
edited
Loading

Codecov Report

Merging #12 (bec09d0) into main (873dc18) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines          127       128    +1     
=========================================
+ Hits           127       128    +1
Impacted Files Coverage Δ
postgres.go 100.00% <100.00%> (ø)
quote.go 100.00% <100.00%> (ø)
util.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873dc18...bec09d0. Read the comment docs.

Fs02
Fs02 reviewed Nov 4, 2021
View reviewed changes
Copy link
Member

@Fs02 Fs02 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we adjust sql as well?

postgres.go Outdated Show resolved Hide resolved
@lafriks lafriks added the enhancement New feature or request label Nov 4, 2021
Fs02
Fs02 approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@Fs02 Fs02 merged commit 6b33dfc into go-rel:main Nov 5, 2021
@lafriks lafriks deleted the fix/tz_format branch November 5, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fs02 Fs02 Fs02 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lafriks @Fs02