Skip to content

Commit

Permalink
remove reload from insert (#138)
Browse files Browse the repository at this point in the history
  • Loading branch information
Fs02 committed Nov 1, 2020
1 parent 676fe74 commit 733b2c6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 75 deletions.
11 changes: 0 additions & 11 deletions repository.go
Original file line number Diff line number Diff line change
Expand Up @@ -334,17 +334,6 @@ func (r repository) insert(cw contextWrapper, doc *Document, mutation Mutation)
doc.SetValue(pField, pValue)
}

if mutation.Reload {
var (
filter = filterDocument(doc)
)

// fetch record
if err := r.find(cw, doc, queriers.Where(filter)); err != nil {
return err
}
}

if mutation.Cascade {
if err := r.saveHasOne(cw, doc, &mutation); err != nil {
return err
Expand Down
64 changes: 0 additions & 64 deletions repository_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -532,70 +532,6 @@ func TestRepository_Insert_sets(t *testing.T) {
adapter.AssertExpectations(t)
}

func TestRepository_Insert_reload(t *testing.T) {
var (
user User
adapter = &testAdapter{}
repo = New(adapter)
mutators = []Mutator{
Reload(true),
Set("name", "name"),
Set("created_at", now()),
Set("updated_at", now()),
}
mutates = map[string]Mutate{
"name": Set("name", "name"),
"created_at": Set("created_at", now()),
"updated_at": Set("updated_at", now()),
}
cur = createCursor(1)
)

adapter.On("Insert", From("users"), mutates).Return(10, nil).Once()
adapter.On("Query", From("users").Where(Eq("id", 10)).Limit(1)).Return(cur, nil).Once()

assert.Nil(t, repo.Insert(context.TODO(), &user, mutators...))
assert.Equal(t, User{
ID: 10,
Name: "name",
CreatedAt: now(),
UpdatedAt: now(),
}, user)
assert.False(t, cur.Next())

adapter.AssertExpectations(t)
cur.AssertExpectations(t)
}

func TestRepository_Insert_reloadError(t *testing.T) {
var (
user User
adapter = &testAdapter{}
repo = New(adapter)
mutators = []Mutator{
Reload(true),
Set("name", "name"),
Set("created_at", now()),
Set("updated_at", now()),
}
mutates = map[string]Mutate{
"name": Set("name", "name"),
"created_at": Set("created_at", now()),
"updated_at": Set("updated_at", now()),
}
cur = &testCursor{}
err = errors.New("error")
)

adapter.On("Insert", From("users"), mutates).Return(10, nil).Once()
adapter.On("Query", From("users").Where(Eq("id", 10)).Limit(1)).Return(cur, err).Once()

assert.Equal(t, err, repo.Insert(context.TODO(), &user, mutators...))

adapter.AssertExpectations(t)
cur.AssertExpectations(t)
}

func TestRepository_Insert_saveBelongsTo(t *testing.T) {
var (
userID = 1
Expand Down

0 comments on commit 733b2c6

Please sign in to comment.