Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timestamp from schema migration builder #160

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Conversation

Fs02
Copy link
Member

@Fs02 Fs02 commented Apr 1, 2021

Different database have different definition for timestamp (at least they are far from 100% compatible), alternative for this is to use Date, DateTime or Time, or define it using raw column builder (t.Column("ts", "timestamp")).

Deprecated at: #156

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #160 (e153542) into master (d61339c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #160   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         3711      3708    -3     
=========================================
- Hits          3711      3708    -3     
Impacted Files Coverage Δ
adapter/sql/config.go 100.00% <ø> (ø)
column.go 100.00% <ø> (ø)
table.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d61339c...e153542. Read the comment docs.

@Fs02 Fs02 mentioned this pull request Apr 1, 2021
@Fs02 Fs02 merged commit 23ab585 into master Apr 1, 2021
@Fs02 Fs02 deleted the remove-timestamp branch April 1, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant