Fixed the construction of query for tables with schema #26
Conversation
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 604 614 +10
=========================================
+ Hits 604 614 +10
Continue to review full report at Codecov.
|
builder/buffer.go
Outdated
| if value == "*" { | ||
| if table == "" { | ||
| return value | ||
| } | ||
| return b.Quoter.ID(table) + ".*" | ||
| return escaped_table + ".*" |
There was a problem hiding this comment.
hmm, maybe we should this field to escapeCache as well, so escape_table doesn't get recomputed everytime
There was a problem hiding this comment.
Actually, I think we store it already.
Lines 162 to 169 in 56e8dba
So I just changed the order for the cache check. If it is done before the computation of the escaped_table, then the key of table/value/quoter reuses the result of escaped value.
Or did you mean that it would be beneficial just to have a separate cache for table names?
There was a problem hiding this comment.
So I just changed the order for the cache check
this is what I mean
There was a problem hiding this comment.
btw, above line should call escapeCache.Store(key, escapedValue) first before returning
There was a problem hiding this comment.
Right... I think it does call the cache store before the return
There was a problem hiding this comment.
looks like it still not updated to store cache before returning? so actually the cache will never be stored
also, I think we can merge this if with below if?
There was a problem hiding this comment.
Yeah, sorry - I misunderstood you. I merged statements, and know "table.*" are cached too
Hi!
There was an issue with querying the database with the schema in the table name, i.e.
select * from user.user where id=$1. I expected that the full table name with schema would deconstructed. However,t he generator gave me such result:SELECT "users.users".* FROM "users"."users" WHERE "users.users"."id"=$1 LIMIT 1;The table name for the FROM clause was constructed as expected, however the
escapefunction does not deconstruct thetablevalue at all.As a result, the query failed, with following error:
pq: missing FROM-clause entry for table "users.users"To fix this I added a small patch that deconstructs the table name for all queries with the table value set.