Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo from WriteLimitOffet to WriteLimitOffset #45

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Conversation

fifsky
Copy link
Contributor

@fifsky fifsky commented Nov 9, 2022

No description provided.

@Fs02
Copy link
Member

Fs02 commented Nov 10, 2022

Thanks for finding this, could you fix the test as well?

@Fs02 Fs02 changed the title typo: modify WriteLimitOffet to WriteLimitOffset Fix typo from WriteLimitOffet to WriteLimitOffset Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d1a6c55) compared to base (3bae971).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          624       624           
=========================================
  Hits           624       624           
Impacted Files Coverage Δ
builder/query.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@Fs02 Fs02 merged commit 1bc6967 into go-rel:main Nov 10, 2022
@fifsky fifsky deleted the patch-1 branch November 10, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants