Skip Alter ADD CONSTRAINT when changing the table schema
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youpy
changed the title
ADD CONSTRAINT when changing the table schema
Fs02
reviewed
Oct 11, 2022
sqlite3.go
Outdated
| _, ok := def.(rel.Key) | ||
| // https://www.sqlite.org/omitted.html | ||
| // > Only the RENAME TABLE, ADD COLUMN, RENAME COLUMN, and DROP COLUMN variants of the ALTER TABLE command are supported. | ||
| if ok && table.Op == rel.SchemaAlter { |
There was a problem hiding this comment.
won't this skip RENAME TABLE, ADD COLUMN, RENAME COLUMN, and DROP COLUMN as well?
There was a problem hiding this comment.
yes. I added tests to verify that they are not skipped.
There was a problem hiding this comment.
oh, I missed _, ok := def.(rel.Key)
can you move above statement inside if table.Op == rel.SchemaAlter? so there's no need to try casting when Op is not SchemaAlter
Fs02
changed the title
ADD CONSTRAINT when changing the table schemaADD CONSTRAINT when changing the table schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: go-rel/sql#39