Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should never try to unmarshal body on http 204 #195

Closed
bradclawsie opened this issue Oct 25, 2018 · 3 comments
Closed

Should never try to unmarshal body on http 204 #195

bradclawsie opened this issue Oct 25, 2018 · 3 comments
Assignees
@jeevatkm
Labels
bug enhancement

Comments

@bradclawsie
Copy link

Spec states that body of http 204 is to be empty and ignored if not. Automatic unmarshal in resty should make an exception for 204.
@jeevatkm jeevatkm self-assigned this Oct 26, 2018
@jeevatkm
Copy link
Member

jeevatkm commented Oct 26, 2018 •
edited

@bradclawsie Could you please describe the use case and why exception is needed for 204 status?

@jeevatkm
Copy link
Member

@bradclawsie Now, I have understood the issue you have described. My bad took a while.

I will apply the update, thank you for reporting it.

jeevatkm added a commit that referenced this issue Oct 28, 2018
@jeevatkm
#195 added check for http status 204 No Content
f8399c4
@jeevatkm
Copy link
Member

Done 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
bug enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradclawsie @jeevatkm