Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the applying order of PathParams #519

Closed
fwang2002 opened this issue Feb 14, 2022 · 2 comments · Fixed by #705
Closed

the applying order of PathParams #519

fwang2002 opened this issue Feb 14, 2022 · 2 comments · Fixed by #705
Assignees
Milestone

Comments

@fwang2002
Copy link

Why first applying PathParams from Request and then Client(in function parseRequestURL). While in other situations, the applying order will be first Client, then Request.

@jeevatkm
Copy link
Member

@fwang2002 Thanks for reporting an issue. I just validated that you're correct. It seems I missed that point during the PR review.
Yes, the first is the client path params, and then the request path params. Typically in resty request values override the client values.

@SVilgelm
Copy link
Contributor

The original implementation was correct, please see the comment in the pull request. I can later today create another pull request with the unit tests

jeevatkm added a commit that referenced this issue Sep 24, 2023
jeevatkm added a commit that referenced this issue Sep 24, 2023
@jeevatkm jeevatkm removed the bug label Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants