Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional retry #37

Closed
wants to merge 5 commits into from
Closed

Conversation

dmiller113
Copy link

Added the ability to add conditions in which to actually retry instead of only on returned errors from the response. This allows you to retry you request again in the case of bad responses in addition to retrying based upon response status codes.

KBallBrabblerAg and others added 4 commits September 16, 2016 11:44
Squashed commits:
[1e0d00b] Removed reference. (+1 squashed commit)
Squashed commits:
[ddbe095] Added backoff retry mechanism.
@codecov-io
Copy link

codecov-io commented Sep 21, 2016

Current coverage is 96.84% (diff: 98.27%)

No coverage report found for master at b353fca.

Powered by Codecov. Last update b353fca...ab1ec43

@dmiller113
Copy link
Author

Depends on #35.

@jeevatkm
Copy link
Member

This is nice. I have went through the changes, it seems you have taken implementation from #35 and then added conditional retry ability.

I have suggestion here.

Can you please hold on for merging #35 (will do as soon as a get a time) and then branch out & add yours? In this way both contributors changes will come to resty separately.

I would like to appreciate both contribution.

@jeevatkm jeevatkm modified the milestone: v0.9 Milestone Sep 22, 2016
@jeevatkm
Copy link
Member

@dmiller113 I have merged #35 to master. Please branch out master and add your conditional retry. I appreciate your efforts.

I'm closing this one.

@jeevatkm jeevatkm self-assigned this Sep 23, 2016
@jeevatkm jeevatkm closed this Sep 23, 2016
@jeevatkm
Copy link
Member

@dmiller113 awaiting your PR, Thanks.

@jeevatkm
Copy link
Member

@dmiller113 I hope you don't mind, if incorporate your contribution into resty and release your contribution.

@jeevatkm jeevatkm reopened this Oct 27, 2016
@jeevatkm jeevatkm closed this Oct 28, 2016
@jeevatkm jeevatkm added this to the v0.9 Milestone milestone Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants