Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RawPathParams without escaping #664

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

SVilgelm
Copy link
Contributor

@SVilgelm SVilgelm commented May 16, 2023

Added RawPathParams options to Client and Request objects to support the path parameters with special characters, like /, without escaping.

Fix #663
Closes #570

Added `RawPathParams` options to `Client` and `Request` objects to support the path parameters with special characters, like `/`, without escaping.

Fix go-resty#663
@SVilgelm
Copy link
Contributor Author

Hi @jeevatkm, could you please review this PR?

@SVilgelm
Copy link
Contributor Author

Hi @jeevatkm, is there a way to get your attention to review this PR?

3JoB added a commit to 3JoB/resty-ilo that referenced this pull request Jul 23, 2023
@jeevatkm jeevatkm self-requested a review September 17, 2023 06:50
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SVilgelm Thanks for your PR, appreciated.

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06% ⚠️

Comparison is base (15cedd4) 95.73% compared to head (1c6f49c) 95.68%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
- Coverage   95.73%   95.68%   -0.06%     
==========================================
  Files          11       11              
  Lines        1571     1598      +27     
==========================================
+ Hits         1504     1529      +25     
  Misses         41       41              
- Partials       26       28       +2     
Files Changed Coverage Δ
client.go 96.52% <100.00%> (-1.45%) ⬇️
middleware.go 92.41% <100.00%> (+1.73%) ⬆️
request.go 95.25% <100.00%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevatkm jeevatkm merged commit ac4743e into go-resty:master Sep 17, 2023
3 checks passed
@SVilgelm SVilgelm deleted the raw-path-params branch September 26, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

there is no way to use PathParams without escaping
2 participants