Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: support js,wasm #683

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Conversation

shynome
Copy link
Contributor

@shynome shynome commented Jul 28, 2023

those code copy from /go/src/net/http/transport_default_other.go

closes #610

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shynome Can you please add test case?

@shynome
Copy link
Contributor Author

shynome commented Sep 17, 2023

I'm sorry, I don't have time to add test case because I don't use resty anymore.
now I just use http client with some function wrap

as you can see, those code is copy from golang std library net/http/transport_default_other.go

@shynome shynome closed this Sep 17, 2023
@jeevatkm
Copy link
Member

@shynome Thanks for getting back. I see; I will take it up later on.

@jeevatkm
Copy link
Member

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11% ⚠️

Comparison is base (15cedd4) 95.73% compared to head (6da8494) 95.63%.
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
- Coverage   95.73%   95.63%   -0.11%     
==========================================
  Files          11       12       +1     
  Lines        1571     1603      +32     
==========================================
+ Hits         1504     1533      +29     
- Misses         41       42       +1     
- Partials       26       28       +2     
Files Changed Coverage Δ
transport.go 100.00% <100.00%> (ø)
transport_other.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevatkm jeevatkm merged commit 0a3c7c8 into go-resty:master Sep 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Protocol not available when updating from go 1.17 to 1.19
2 participants