Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix OnBeforeRequst doc application order #701

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

leejuyuu
Copy link
Contributor

The documentation about the order of middleware application for OnBeforeRequet was different from the implementation. Fixed this by changing the documentation.

Fixes #686.

The documentation about the order of middleware application
for OnBeforeRequet was different from the implementation. Fixed this by
changing the documentation.

Fixes go-resty#686.
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leejuyuu Thanks for your PR to correct the docs.

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9ef9b6f) 95.65% compared to head (ce4aaac) 95.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #701   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files          12       12           
  Lines        1611     1611           
=======================================
  Hits         1541     1541           
  Misses         42       42           
  Partials       28       28           
Files Changed Coverage Δ
client.go 96.52% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevatkm jeevatkm merged commit 7c1134f into go-resty:master Sep 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

OnBeforeRequest and default middleware order documentation and code mismatch
2 participants