Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section about proxy #88

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Add section about proxy #88

merged 3 commits into from
Jul 12, 2022

Conversation

lexuzieel
Copy link

@lexuzieel lexuzieel commented Jul 11, 2022

Hello! I have spent more time than I want to admit in order to make proxy with authentication work. 😆
I feel like it might be helpful to other folks if we add a more detailed section to the documentation on how to use proxy.
In particular a note on how to use MustHandleAuth, since it must be called as a goroutine.

Copy link
Member

@ysmood ysmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 👍🏼

Please fix the error of go test

@lexuzieel
Copy link
Author

Done 😄

@ysmood ysmood merged commit fad82b6 into go-rod:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants