use Must

resolve #116

browser.go

@@ -163,13 +163,13 @@ func (b *Browser) ConnectE() (err error) {
 			b.client = launcher.NewRemote(u).Client()
 		} else {
 			if u == "" {
-				u = launcher.New().Context(b.ctx).Launch()
+				u = launcher.New().Context(b.ctx).MustLaunch()
 			}
 			b.client = cdp.New(u)
 		}
 	}
 
-	b.client.Context(b.ctx, b.ctxCancel).Connect()
+	b.client.Context(b.ctx, b.ctxCancel).MustConnect()
 
 	b.monitorServer = b.ServeMonitor(defaults.Monitor, !defaults.Blind)
 

examples_test.go

@@ -96,7 +96,7 @@ func Example_headless_with_debug() {
 	url := launcher.New().
 		Headless(false).
 		Devtools(true).
-		Launch()
+		MustLaunch()
 
 	// Trace shows verbose debug information for each action executed
 	// Slowmotion is a debug related function that waits 2 seconds between
@@ -226,7 +226,7 @@ func Example_customize_browser_launch() {
 		Set("proxy-server", "127.0.0.1:8080").
 		// Delete a flag- remove the mock-keychain flag
 		Delete("use-mock-keychain").
-		Launch()
+		MustLaunch()
 
 	browser := rod.New().ControlURL(url).Connect()
 	defer browser.Close()

fixtures/gen-fonts/main.go

@@ -16,7 +16,7 @@ import (
 )
 
 func main() {
-	url := launcher.New().Headless(true).Launch()
+	url := launcher.New().Headless(true).MustLaunch()
 	b := rod.New().ControlURL(url).Connect()
 	defer b.Close()
 

lib/cdp/example_test.go

@@ -12,10 +12,10 @@ import (
 
 func ExampleClient() {
 	// launch a browser
-	url := launcher.New().Headless(false).Launch()
+	url := launcher.New().Headless(false).MustLaunch()
 
 	// create a controller
-	client := cdp.New(url).Connect()
+	client := cdp.New(url).MustConnect()
 
 	// Such as call this endpoint on the api doc:
 	// https://chromedevtools.github.io/devtools-protocol/tot/Page#method-navigate

lib/cdp/main.go

@@ -125,8 +125,8 @@ func (cdp *Client) DebugLog(fn func(interface{})) *Client {
 	return cdp
 }
 
-// ConnectE to browser
-func (cdp *Client) ConnectE() error {
+// Connect to browser
+func (cdp *Client) Connect() error {
 	if cdp.ws == nil {
 		cdp.ws = NewDefaultWsClient()
 	}
@@ -145,9 +145,9 @@ func (cdp *Client) ConnectE() error {
 	return nil
 }
 
-// Connect to browser
-func (cdp *Client) Connect() *Client {
-	utils.E(cdp.ConnectE())
+// MustConnect to browser
+func (cdp *Client) MustConnect() *Client {
+	utils.E(cdp.Connect())
 	return cdp
 }
 

lib/cdp/main_test.go

@@ -18,9 +18,9 @@ func TestBasic(t *testing.T) {
 	ctx, done := context.WithCancel(context.Background())
 	defer done()
 
-	url := launcher.New().Launch()
+	url := launcher.New().MustLaunch()
 
-	client := cdp.New(url).Context(ctx, done).Websocket(nil).Header(http.Header{"test": {}}).Connect()
+	client := cdp.New(url).Context(ctx, done).Websocket(nil).Header(http.Header{"test": {}}).MustConnect()
 
 	defer func() {
 		utils.E(client.Call(ctx, "", "Browser.close", nil))
@@ -119,15 +119,15 @@ func TestError(t *testing.T) {
 	assert.Equal(t, "{\"code\":10,\"message\":\"err\",\"data\":\"data\"}", cdpErr.Error())
 
 	assert.Panics(t, func() {
-		cdp.New("").Connect()
+		cdp.New("").MustConnect()
 	})
 }
 
 func TestCrash(t *testing.T) {
 	ctx := context.Background()
 	l := launcher.New()
 
-	client := cdp.New(l.Launch()).Debug(true).Connect()
+	client := cdp.New(l.MustLaunch()).Debug(true).MustConnect()
 
 	go func() {
 		for range client.Event() {

lib/devices/utils_test.go

@@ -7,7 +7,7 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func TestE(t *testing.T) {
+func TestErr(t *testing.T) {
 	v := devices.GetViewport(devices.IPad, false)
 	assert.EqualValues(t, 768, v.Width)
 	assert.EqualValues(t, 1024, v.Height)

lib/examples/use-rod-like-chrome-extension/main.go

@@ -10,7 +10,7 @@ import (
 func main() {
 	// Make sure you have closed your browser completely, UserMode can't control a browser that is not launched by it.
 	// Launches a new browser with the "new user mode" option, and returns the URL to control that browser.
-	url := launcher.NewUserMode().Launch()
+	url := launcher.NewUserMode().MustLaunch()
 
 	browser := rod.New().ControlURL(url).Connect()
 

lib/launcher/basic_test.go

@@ -44,7 +44,7 @@ func TestLaunch(t *testing.T) {
 		_ = kit.KillTree(l.PID())
 	}()
 
-	url := l.Launch()
+	url := l.MustLaunch()
 
 	assert.NotEmpty(t, url)
 }
@@ -71,11 +71,11 @@ func TestLaunchUserMode(t *testing.T) {
 		Headless(false).Headless(true).RemoteDebuggingPort(port).
 		Devtools(true).Devtools(false).Reap(true).
 		UserDataDir("test").UserDataDir(dir).
-		Launch()
+		MustLaunch()
 
 	assert.Equal(t,
 		url,
-		launcher.NewUserMode().RemoteDebuggingPort(port).Launch(),
+		launcher.NewUserMode().RemoteDebuggingPort(port).MustLaunch(),
 	)
 }
 
@@ -84,10 +84,10 @@ func TestOpen(t *testing.T) {
 }
 
 func TestUserModeErr(t *testing.T) {
-	_, err := launcher.NewUserMode().RemoteDebuggingPort(48277).Bin("not-exists").LaunchE()
+	_, err := launcher.NewUserMode().RemoteDebuggingPort(48277).Bin("not-exists").Launch()
 	assert.Error(t, err)
 
-	_, err = launcher.NewUserMode().RemoteDebuggingPort(58217).Bin("echo").LaunchE()
+	_, err = launcher.NewUserMode().RemoteDebuggingPort(58217).Bin("echo").Launch()
 	assert.Error(t, err)
 }
 
@@ -98,9 +98,9 @@ func TestGetWebSocketDebuggerURLErr(t *testing.T) {
 
 func TestLaunchErr(t *testing.T) {
 	assert.Panics(t, func() {
-		launcher.New().Bin("not-exists").Launch()
+		launcher.New().Bin("not-exists").MustLaunch()
 	})
 	assert.Panics(t, func() {
-		launcher.New().Headless(false).Bin("not-exists").Launch()
+		launcher.New().Headless(false).Bin("not-exists").MustLaunch()
 	})
 }

lib/launcher/launcher.go

@@ -245,17 +245,17 @@ func (l *Launcher) Reap(enable bool) *Launcher {
 	return l
 }
 
-// Launch a standalone temp browser instance and returns the debug url.
+// MustLaunch a standalone temp browser instance and returns the debug url.
 // bin and profileDir are optional, set them to empty to use the default values.
 // If you want to reuse sessions, such as cookies, set the userDataDir to the same location.
-func (l *Launcher) Launch() string {
-	u, err := l.LaunchE()
+func (l *Launcher) MustLaunch() string {
+	u, err := l.Launch()
 	utils.E(err)
 	return u
 }
 
-// LaunchE doc is similar to the method Launch
-func (l *Launcher) LaunchE() (wsURL string, err error) {
+// Launch doc is similar to the method Launch
+func (l *Launcher) Launch() (wsURL string, err error) {
 	defer func() {
 		if e := recover(); e != nil {
 			err = e.(error)

lib/launcher/private_test.go

@@ -78,7 +78,7 @@ func TestRemoteLaunch(t *testing.T) {
 	u := "ws://" + srv.Listener.Addr().String()
 	l := NewRemote(u).KeepUserDataDir()
 	client := l.Delete("keep-user-data-dir").Client()
-	b := client.Context(ctx, cancel).Connect()
+	b := client.Context(ctx, cancel).MustConnect()
 	utils.E(b.Call(ctx, "", "Browser.getVersion", nil))
 	_, _ = b.Call(ctx, "", "Browser.close", nil)
 	dir, _ := l.Get("user-data-dir")
@@ -96,6 +96,6 @@ func TestLaunchErr(t *testing.T) {
 	go func() {
 		l.exit <- utils.Nil{}
 	}()
-	_, err := l.LaunchE()
+	_, err := l.Launch()
 	assert.Error(t, err)
 }

lib/launcher/proxy.go

@@ -104,7 +104,7 @@ func (p *Proxy) launch(w http.ResponseWriter, r *http.Request) {
 		utils.E(json.Unmarshal([]byte(options), l))
 	}
 
-	u := l.Launch()
+	u := l.MustLaunch()
 	defer func() {
 		proc, err := os.FindProcess(l.PID())
 		l.kill()

lib/proto/generate/utils.go

@@ -23,7 +23,7 @@ func getSchema() gjson.Result {
 		}
 	}()
 
-	u := l.Launch()
+	u := l.MustLaunch()
 	parsed, err := url.Parse(u)
 	utils.E(err)
 	parsed.Scheme = "http"

lib/proto/utils.go

@@ -85,13 +85,6 @@ func Normalize(m interface{}) (json.RawMessage, error) {
 	return json.Marshal(m)
 }
 
-// E panics err if err not nil
-func E(err error) {
-	if err != nil {
-		panic(err)
-	}
-}
-
 // JSON value
 type JSON struct {
 	gjson.Result

lib/proto/utils_test.go

@@ -58,12 +58,6 @@ func TestCall(t *testing.T) {
 	assert.Error(t, err)
 }
 
-func TestE(t *testing.T) {
-	assert.Panics(t, func() {
-		proto.E(errors.New("err"))
-	})
-}
-
 func TestParseMethodName(t *testing.T) {
 	d, n := proto.ParseMethodName("Page.enable")
 	assert.Equal(t, "Page", d)

lib/utils/main_test.go

@@ -8,7 +8,7 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func TestE(t *testing.T) {
+func TestErr(t *testing.T) {
 	utils.E(nil)
 
 	assert.Panics(t, func() {

setup_test.go

@@ -50,7 +50,7 @@ func Test(t *testing.T) {
 	u := launcher.New().
 		Delete("disable-extensions").
 		Set("load-extension", extPath).
-		Launch()
+		MustLaunch()
 
 	s := new(S)
 	s.client = cdp.New(u)