Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We shouldn't publish event asynchronously #34

Closed
ysmood opened this issue May 19, 2020 · 0 comments
Closed

We shouldn't publish event asynchronously #34

ysmood opened this issue May 19, 2020 · 0 comments
Assignees
@ysmood
Labels
bug When you are sure about it's a bug

Comments

@ysmood
Copy link
Member

ysmood commented May 19, 2020

It may cause an unexcepted order or event stream.

https://github.com/ysmood/rod/blob/f9774865a0ddedd0914e2cacd7b83678ae398e3d/browser.go#L280-L282
@ysmood ysmood added the bug When you are sure about it's a bug label May 19, 2020
@ysmood ysmood self-assigned this May 19, 2020
@ysmood ysmood closed this as completed in b7395e4 May 19, 2020
@ysmood ysmood reopened this May 21, 2020
ysmood added a commit that referenced this issue May 21, 2020
@ysmood
make sure event stream are synchronous
2b63208 
fix #34
ysmood added a commit that referenced this issue May 22, 2020
@ysmood
make sure event stream are synchronous
1da5f05 
fix #34
@ysmood ysmood closed this as completed in 5926a36 May 26, 2020
ysmood added a commit that referenced this issue May 26, 2020
@ysmood
make sure event stream are synchronous
3ce0f98 
fix #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ysmood ysmood

Labels
bug When you are sure about it's a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ysmood