Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HijackRouter 注释说明有冲突 #926

Closed
xujinzheng opened this issue Aug 27, 2023 · 2 comments
Closed

HijackRouter 注释说明有冲突 #926

xujinzheng opened this issue Aug 27, 2023 · 2 comments
Labels
doc Improvements or additions to documentation

Comments

@xujinzheng
Copy link
Contributor

见字体加粗部分

https://github.com/go-rod/rod/blob/main/hijack.go#L114
// You can add new handler even after the "Run" is called.
func (r *HijackRouter) Add(pattern string, resourceType proto.NetworkResourceType, handler func(*Hijack)) error {}

https://github.com/go-rod/rod/blob/main/hijack.go#L184
// Run the router, after you call it, you shouldn't add new handler to it.
func (r *HijackRouter) Run() {
r.run()
}

@xujinzheng xujinzheng added the question Questions related to rod label Aug 27, 2023
@github-actions
Copy link

Please add a valid Rod Version: v0.0.0 to your issue. Current version is v0.114.3

generated by check-issue

@ysmood ysmood added bug When you are sure about it's a bug and removed question Questions related to rod labels Aug 27, 2023
@ysmood
Copy link
Member

ysmood commented Aug 27, 2023

多谢指正,能帮忙建个 PR 修正这个问题吗?应该删除 You can add new handler even after the "Run" is called.

@ysmood ysmood added doc Improvements or additions to documentation and removed bug When you are sure about it's a bug labels Aug 27, 2023
xujinzheng added a commit to xujinzheng/rod that referenced this issue Aug 29, 2023
@ysmood ysmood closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants