Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TriggerFavicon #884

Merged
merged 8 commits into from
Jun 6, 2023
Merged

feat: TriggerFavicon #884

merged 8 commits into from
Jun 6, 2023

Conversation

Fly-Playgroud
Copy link
Contributor

1.support in headless mode to trigger favicon request.
2.when call it in no-headless mode will raise an error with message:browser is no-headless

#680

1.support in headless mode to trigger favicon request.
2.when call it in no-headless mode will raise an error with message:browser is no-headless
@Fly-Playgroud Fly-Playgroud requested a review from ysmood June 2, 2023 10:26
@Fly-Playgroud Fly-Playgroud self-assigned this Jun 2, 2023
@Fly-Playgroud Fly-Playgroud added the enhance New feature or request label Jun 2, 2023
ysmood
ysmood previously approved these changes Jun 3, 2023
@ysmood ysmood enabled auto-merge (squash) June 3, 2023 15:41
auto-merge was automatically disabled June 4, 2023 02:09

Head branch was pushed to by a user without write access

page_test.go Outdated Show resolved Hide resolved
page_test.go Outdated Show resolved Hide resolved
page_test.go Outdated Show resolved Hide resolved
page_test.go Outdated Show resolved Hide resolved
page_test.go Outdated Show resolved Hide resolved
page_test.go Outdated Show resolved Hide resolved
Fly-Playgroud and others added 3 commits June 6, 2023 10:18
Co-authored-by: Yad Smood <ysmood@users.noreply.github.com>
Co-authored-by: Yad Smood <ysmood@users.noreply.github.com>
page_test.go Outdated Show resolved Hide resolved
@Fly-Playgroud Fly-Playgroud requested a review from ysmood June 6, 2023 04:49
@ysmood ysmood merged commit 50b30c0 into go-rod:main Jun 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants