Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add InputColor #919

Merged
merged 1 commit into from Aug 22, 2023
Merged

add InputColor #919

merged 1 commit into from Aug 22, 2023

Conversation

madflow
Copy link
Contributor

@madflow madflow commented Aug 20, 2023

  • This is a follow up to Input Type color #918
  • Not sure, if this qualifies as seperate input method.
  • I basically looked at InputTime and adapted it.

ysmood
ysmood previously approved these changes Aug 20, 2023
View reviewed changes
@ysmood ysmood enabled auto-merge (squash) August 20, 2023 16:04
@ysmood
Copy link
Collaborator

ysmood commented Aug 21, 2023

Please fix the code coverage error in CI, here's how:

https://github.com/go-rod/rod/blob/main/.github/CONTRIBUTING.md#code-coverage

auto-merge was automatically disabled August 21, 2023 19:59

Head branch was pushed to by a user without write access

@madflow
Copy link
Contributor Author

madflow commented Aug 22, 2023

I fixed the coverage, adapting the things from element.InputTime

@ysmood ysmood merged commit eff7c97 into go-rod:main Aug 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysmood ysmood ysmood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@madflow @ysmood