feat: Change initial release to work as expected

go-semantic-release · Apr 25, 2020 · f058d54 · f058d54
1 parent 8afe7e8
commit f058d54
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/pkg/semrel/semrel.go b/pkg/semrel/semrel.go
@@ -114,9 +114,6 @@ func CalculateChange(commits []*Commit, latestRelease *Release) Change {
 }
 
 func ApplyChange(version *semver.Version, change Change) *semver.Version {
-	if version.Major() == 0 {
-		change.Major = true
-	}
 	if !change.Major && !change.Minor && !change.Patch {
 		return nil
 	}

diff --git a/pkg/semrel/semrel_test.go b/pkg/semrel/semrel_test.go
@@ -41,9 +41,9 @@ func TestApplyChange(t *testing.T) {
 		expectedVersion string
 	}{
 		// No Previous Releases
-		{"0.0.0", NoChange, "1.0.0"},
-		{"0.0.0", PatchChange, "1.0.0"},
-		{"0.0.0", MinorChange, "1.0.0"},
+		{"0.0.0", NoChange, "0.0.0"},
+		{"0.0.0", PatchChange, "0.0.1"},
+		{"0.0.0", MinorChange, "0.1.0"},
 		{"0.0.0", MajorChange, "1.0.0"},
 
 		{"1.0.0", NoChange, ""},
@@ -68,7 +68,7 @@ func TestApplyChange(t *testing.T) {
 			actual := ApplyChange(current, tc.change)
 
 			// Handle no new version case
-			if actual != nil && tc.expectedVersion == "" {
+			if actual != nil && tc.expectedVersion != "" {
 				if actual.String() != tc.expectedVersion {
 					t.Errorf("expected: %s, got: %s", tc.expectedVersion, actual)
 				}