Is mapping ci-condition-opt from the command line wrong?

[ted-vo]

Hi!
My repo setting default branch: develop
I just want to use ci-condition-opt to override defaultBranch.
My command:
./semantic-release --provider gitlab --ci-condition gitlab --ci-condition-opt defaultBranch="*" --token ***

I see code override ci-condition-opt here:

semantic-release/cmd/semantic-release/main.go

Line 168 in 5c34391

for k, v := range conf.CIConditionOpts {

and pass the conf to condition-gitlab and run condition here:
https://github.com/go-semantic-release/condition-gitlab/blob/268fae569178cdfc0b17da5122fa30c7d77f8a03/pkg/condition/gitlab.go#L34

Expected behavior:
It should be py pass defaultBranch to "*"

Actual behavior:
defaultBranch run atcondition-gitlab.RunCondition still is value from repoInfo.DefaultBranch

---

Try to debug:
I just build go-semantic-release by myself to log what it happended

Result is in a picture. Value defaultBranch="*" from commend line has been change to defaultbranch:* (key was lowercase). But actual key is defaultBranch pass to RunCondition.

Is it a bug?

p/s: Sorry because English is not my primary language.

[christophwitzko]

Hey @ted-v9n, thanks for investigating this.
You are right, passed options are converted to the lowercase representation:

semantic-release/pkg/config/config.go

Line 78 in 5c34391

opts[strings.ToLower(sOpt[0])] = sOpt[1]

So yes, this is a bug and it is currently impossible to overwrite camelCase configuration options. In your case, you could try the --no-ci flag to skip the ci condition.

[ted-vo]

Hi @christophwitzko , thank you so much. I appiled --no-ci to workaround. 👌

[christophwitzko]

awesome, I also fixed it with the next release 🎉