Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update namespace #1

Merged
merged 5 commits into from
Aug 29, 2023
Merged

update namespace #1

merged 5 commits into from
Aug 29, 2023

Conversation

Monirzadeh
Copy link

@Monirzadeh Monirzadeh commented Aug 28, 2023

Try update namespace of project from github.com/bmaupin/go-epub to github.com/go-shiori/go-epub

@fmartingr
Copy link
Member

Some missing things:

  • There are some links in the README.md as well.
  • Add a new line to the LICENSE file below Copyright (c) 2016 bmaupin: Copyright (c) 2023 Go-Shiori team

@Monirzadeh
Copy link
Author

is it good enough? i think pkgsite and goreportcard work after merge am i right?

@Monirzadeh Monirzadeh marked this pull request as ready for review August 29, 2023 10:14
@fmartingr
Copy link
Member

is it good enough? i think pkgsite and goreportcard work after merge am i right?

Yeah I think that will work once their are on the main branch. I will check if there's something I need to setup on those services.

@Monirzadeh Monirzadeh enabled auto-merge (squash) August 29, 2023 10:41
@Monirzadeh Monirzadeh requested review from a team and fmartingr and removed request for a team August 29, 2023 10:41
fmartingr
fmartingr previously approved these changes Aug 29, 2023
Copy link
Member

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the reference to bmaupin/go-docs-epub since it's archived and we should aim to provide examples directly in code. ref

And I'm not sure if we'll need to fork bmaupin/epub-samples as well in the future, we'll see.

@Monirzadeh
Copy link
Author

Monirzadeh commented Aug 29, 2023

I think we can remove the reference to bmaupin/go-docs-epub since it's archived and we should aim to provide examples directly in code. ref

And I'm not sure if we'll need to fork bmaupin/epub-samples as well in the future, we'll see.

No, we don't need fork that i will add more documentation later for other contributors.
but should i remove some comment in code like this right now

// Sample: https://github.com/bmaupin/epub-samples/blob/master/minimal-v3plus2/EPUB/package.opf

@fmartingr
Copy link
Member

but should i remove some comment in code like this right now

Not at the moment, since content is still accesible.

@fmartingr fmartingr merged commit 9229546 into go-shiori:main Aug 29, 2023
3 checks passed
@Monirzadeh Monirzadeh deleted the update-namespace branch August 30, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants