Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add file extension at the end of filename if not provided #20

Merged
merged 10 commits into from
Dec 31, 2023
Merged

fix: add file extension at the end of filename if not provided #20

merged 10 commits into from
Dec 31, 2023

Conversation

Monirzadeh
Copy link

this pull request try to fix #14 and add some more unit test for addSection function

@Monirzadeh Monirzadeh added this to the v1.3.0 milestone Dec 25, 2023
fmartingr
fmartingr requested changes Dec 27, 2023
View reviewed changes
Copy link
Member

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some text typos and a question

epub_test.go Outdated Show resolved Hide resolved
epub_test.go Outdated Show resolved Hide resolved
epub_test.go Outdated Show resolved Hide resolved
Monirzadeh and others added 3 commits December 27, 2023 19:28
@Monirzadeh @fmartingr
Better name for unittest
324c305 
Co-authored-by: Felipe Martin <812088+fmartingr@users.noreply.github.com>
@Monirzadeh @fmartingr
Update epub_test.go
7113bf5 
Co-authored-by: Felipe Martin <812088+fmartingr@users.noreply.github.com>
@Monirzadeh
better unittest name
448fa38
fmartingr
fmartingr previously approved these changes Dec 30, 2023
View reviewed changes
@Monirzadeh Monirzadeh self-assigned this Dec 30, 2023
@fmartingr fmartingr changed the title fix: add fileforamt at the end of custom filename if that not provide by user fix: add file extension at the end of filename if not provided Dec 31, 2023
fmartingr
fmartingr reviewed Dec 31, 2023
View reviewed changes
epub.go Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7370105534

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.7%) to 88.836%
Totals Coverage Status
Change from base Build 7369905800: 2.7%
Covered Lines: 1130
Relevant Lines: 1272
💛 - Coveralls

@Monirzadeh Monirzadeh merged commit 9c10b06 into go-shiori:main Dec 31, 2023
4 checks passed
@Monirzadeh Monirzadeh deleted the unittest branch December 31, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmartingr fmartingr fmartingr approved these changes

Assignees

@Monirzadeh Monirzadeh

Labels
None yet
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging this pull request may close these issues.

if custom filename don't have extension it should return error or automaticaly fix
3 participants
@Monirzadeh @coveralls @fmartingr