Add more formats for dates to parse #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmartingr
requested changes
May 18, 2024
There was a problem hiding this comment.
Hey @vianse, thank you for the contribution. I believe the log was there to easily see in the logs what datietime couldn't be parsed, I don't mind it being there since we don't know that happened otherwise (since that function returns always nil). In the future we can refactor this function to properly return an error when it fails to parse a datetime as it should but that log is the only mention that something failed.
Probably you can just add it above the return nil instead of the weird else statement.
This was referenced May 18, 2024
|
IMO #46 better addresses the problem, so let's discard this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, removed Printf, seems like forgotten debug remainder.