Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tags by space, not comma #16

Closed
wants to merge 1 commit into from
Closed

Split tags by space, not comma #16

wants to merge 1 commit into from

Conversation

p3lim
Copy link
Contributor

@p3lim p3lim commented Jan 15, 2020

It's way more intuitive in my opinion, fixing uncertainties like in #9.

If not merged as-is, please provide it as an option.

It's way more intuitive
@p3lim
Copy link
Contributor Author

p3lim commented Jan 15, 2020

For those who wants to test this, I created a signed XPI file from this PR (and my other 3) available on my fork: https://github.com/p3lim/shiori-web-ext/releases/tag/0.8.4

@hasso
Copy link

hasso commented Jan 20, 2020

I use a lot of tags containing spaces. I think that I'm not the only one.

@fmartingr
Copy link
Member

Thanks for your contribution @p3lim, but I'm in the same boat as @hasso: my tags contains spaces and I'm used to commas for list separation (which is the same being used in the shiori frontend). Maybe some kind of autocompletion for tags will be more useable? (that way pressing would append the tag and the comma automatically, or with a special tag input of some sort).

Since the extension will still remain in beta for some time until I sort everything in the org I'm leaving this behaviour as is, in the meanwhile we can open a feature request to discuss how to move forward with this one.

@fmartingr fmartingr closed this Feb 14, 2022
@p3lim p3lim deleted the tags-key-space branch February 15, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants