feat: add custom search-engine to query shiori #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @patrickpichler thanks for the contribution! This seems super useful. One question before a proper review, how will browsers that don't support omnibox react to this? Will the execution break since |
|
Great question, I have no idea tbh! Is the extension supported for Safari? |
I'd say is not officially supported for any browser, since it's mostly an alpha. Just trying to avoid crashes as much as possible. Maybe just adding an |
|
Sounds good 👌 🙂 |
It is now possible to query Shiori directly from the firefox search bar by simply prefixing the query with `@shiori`. This will trigger a shiori keyword search. It is also possible to search by tags, by prefixing words with `#`. fixes: go-shiori#58
patrickpichler
force-pushed
the
feature/add-searchengine
branch
from
ae4c396
to
c4fe2be
Compare
|
I wrapped it in an if :) |
fmartingr
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to query Shiori directly from the firefox search bar by simply prefixing the query with
@shiori. This will trigger a shiori keyword search. It is also possible to search by tags, by prefixing words with#.fixes: #58