Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server error with CSS files with new version #445

Closed
pgrunm opened this issue Jun 28, 2022 · 4 comments · Fixed by #448
Closed

Server error with CSS files with new version #445

pgrunm opened this issue Jun 28, 2022 · 4 comments · Fixed by #448
Milestone

Comments

@pgrunm
Copy link

pgrunm commented Jun 28, 2022

Hello, I'm running Shiori with my Raspberry pi behind a Caddy reverse proxy. I followed the guide here to run Shiori behind Caddy as reverse proxy.

Until the last update everything was fine, but since 1.5.3 any CSS file isn't loaded correctly if you run Shiori like this shiori serve --webroot /shiori/ parameter. In Firefox I can see internal server errors (HTTP code 500) and this is also displayed on the console but no further information.

image

The page as result looks like this now:

image

And now the great part: If you run Shiori without the --webroot /shiori/ parameter, everything is fine. I also verified this on my local machine, once with the parameter and once without, same result as with the Raspberry Pi, without reverse proxy of course.

Steps to reproduce

  • Download Shiori (if not already in path or something)
  • Extract and run with to test: shiori serve --webroot /shiori/ and open up Shiori http://127.0.0.1:8080/shiori/. This is how no CSS is displayed.
  • To verify the working state run Shiori like this: shiori serve and open Shiori again.
  • If I try to open the source-sans-pro.min.css file as an example my browser says the following: open /css/source-sans-pro.min.css: invalid name. The corresponding log entry from the containers log is:
    time="2022-06-28T17:43:40Z" level=warning msg="GET /shiori/css/source-sans-pro.min.css" proto=HTTP/1.1 remote="172.19.0.2:43460" reqlen=0 size=48 status=500
@hulb
Copy link
Contributor

hulb commented Jul 6, 2022

Sorry for your trouble, it will be fixed when the PR merged

@pgrunm
Copy link
Author

pgrunm commented Jul 7, 2022

No problem, I appreciate your upcoming fix. :-)

@fmartingr
Copy link
Member

Hey @pgrunm, I just merged @hulb's fix. Please check if this solves it, if not, please reopen the issue so we can take a look.

@pgrunm
Copy link
Author

pgrunm commented Jul 8, 2022

Works great, thank you very much! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants