Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated epub files can't be imported into Apple Books #638

Closed
fmartingr opened this issue Jul 9, 2023 · 4 comments · Fixed by #679
Closed

Generated epub files can't be imported into Apple Books #638

fmartingr opened this issue Jul 9, 2023 · 4 comments · Fixed by #679
Assignees
@Monirzadeh
Labels
type:bug Something isn't working
Milestone
1.6.0

Comments

@fmartingr
Copy link
Member

Data

  • Shiori version: 1.5.5-rc.1
  • Database Engine: PostgreSQL
  • Operating system: Docker Image
  • CLI/Web interface/Web Extension: --

Describe the bug / actual behavior

Generated epub files fails importing into Apple Books (macOS) without any relevant error.

Expected behavior

Generated epub files should work with Apple Books.

Screenshots

Screenshot 2023-07-09 at 14 09 13
@fmartingr fmartingr added the type:bug Something isn't working label Jul 9, 2023
@Monirzadeh
Copy link
Collaborator

Monirzadeh commented Jul 9, 2023 •
edited
Loading

Can you confirm that you can open generated e-book in other program, maybe caliber e-book viewer for mac or other like KOReader without problem?

@fmartingr
Copy link
Member Author

Can you confirm that you can open generated e-book in other program, maybe caliber e-book viewer for mac or other like KOReader without problem?

For testing I use epub-reader.online and that works, so it has to be something related to apple books. Is not high-priority so don't worry about this too much.

@Monirzadeh
Copy link
Collaborator

Monirzadeh commented Jul 26, 2023 •
edited
Loading

@fmartingr Hi
can you please test this 3 EPUB and see if any of them can import in Apple books?
ebooksample.zip

@fmartingr
Copy link
Member Author

2 and 3 imported correctly. 1 did not import:

Screenshot 2023-07-27 at 08 24 13

Monirzadeh added a commit to Monirzadeh/shiori that referenced this issue Jul 27, 2023
@Monirzadeh
fix apple books cannot import generated book with shiori fix go-shior…
10a6275 
…i#638
@Monirzadeh Monirzadeh mentioned this issue Jul 27, 2023
Merged
5 tasks
@fmartingr fmartingr added this to the 1.6.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Monirzadeh Monirzadeh

Labels
type:bug Something isn't working
Projects
Roadmap
Archived in project
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

refactor: Migrate ePub generation to go-epub Monirzadeh/shiori
2 participants
@fmartingr @Monirzadeh