We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
You cannot provide a mysql connection string that is accepted by both the driver and the application.
The problem is that it parses the connection string looking for a schema, but it won't be stripped from the string that is passed to the driver: https://github.com/go-shiori/shiori/blob/master/internal/database/database.go#L57
But the driver itself doesn't accept a scheme: https://github.com/go-sql-driver/mysql#dsn-data-source-name
Furthermore, the new connection string is preferred, but the documentation is still using the old way.
It connects to mysql instance.
Steps to reproduce the behavior:
shiori:passwd@(mysql)/shiori?charset=utf8mb4
mysql://shiori:passwd@(mysql)/shiori?charset=utf8mb4
I'll create a PR for it later on. :D
The text was updated successfully, but these errors were encountered:
Fixes go-shiori#729.
17fdd48
Mysql connection string update, docs update
rutkai
Successfully merging a pull request may close this issue.
Data
Describe the bug / actual behavior
You cannot provide a mysql connection string that is accepted by both the driver and the application.
The problem is that it parses the connection string looking for a schema, but it won't be stripped from the string that is passed to the driver:
https://github.com/go-shiori/shiori/blob/master/internal/database/database.go#L57
But the driver itself doesn't accept a scheme:
https://github.com/go-sql-driver/mysql#dsn-data-source-name
Furthermore, the new connection string is preferred, but the documentation is still using the old way.
Expected behavior
It connects to mysql instance.
To Reproduce
Steps to reproduce the behavior:
shiori:passwd@(mysql)/shiori?charset=utf8mb4
mysql://shiori:passwd@(mysql)/shiori?charset=utf8mb4
Notes
I'll create a PR for it later on. :D
The text was updated successfully, but these errors were encountered: