Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchors in URLs get encoded incorrectly #91

Closed
muesli opened this issue May 2, 2018 · 4 comments
Closed

Anchors in URLs get encoded incorrectly #91

muesli opened this issue May 2, 2018 · 4 comments

Comments

@muesli
Copy link
Contributor

muesli commented May 2, 2018

When storing a URL with an anchor (e.g. https://foo#bar) the hash character gets encoded incorrectly as %23.

@RadhiFadlillah
Copy link
Collaborator

@muesli thanks for the report. This happened because url.ParseRequestURI (which used for validating URL) always assume that the raw URL string doesn't have any #fragment suffix.

To fix this, I've reverted ParseRequestURI to normal Parse in 1baf921. I've also removed the fragment from URL in 7532d36 because AFAIK the anchor tag (#) is only used by web browser, and not by web server.

@RadhiFadlillah
Copy link
Collaborator

Hi @muesli, I’m closing this issue for now because :

  • It has been fixed, and;
  • It has been inactive for a while, so I guess this issue has been solved.

Feels free to reopen it if needed.

Thank you.

@mailinglists35
Copy link

this is not fixed. i still cannot add url with anchor. using latest release binary. if it is fixed in master, perhaps could you try make a new release or at least a snapshot of the current master?

@mailinglists35
Copy link

i mean... i really want to store an url containing a fragment.... :) the fix was to remove support for fragments altogether :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants