preserve fragment in URLs (#315)

[arakimo]

I encountered this issue myself while using shiori, so I figured I would have a go. I'm fairly new to git/programming, so... apologies in advance for any mistakes :)

Should fix #315

[fmartingr]

Hey @arakimo, thanks for checking this out!

Your solution works, but I'm just wondering if isn't it easier just to remove the tmp.Fragment = "" line. We are removing it manually and I'm not sure of the reason. Did you try that before?

@RadhiFadlillah long shot, but... do you remember the reason?

[arakimo]

I assumed that the fragment was being removed manually before queryEncodeWithoutEmptyValues(queries) to prevent the fragment from being encoded (i.e. turning the # into a %23), but I just tested your suggestion and it seems to work perfectly, so I'm not sure why tmp.Fragment = "" is there either.

It was mentioned in (#91) that the code used to use ParseRequestURI(), which unlike Parse() assumed that the string provided would not have a fragment. Maybe manually clearing the fragment is a remnant of that? I'm not sure.

[fmartingr]

I assumed that the fragment was being removed manually before queryEncodeWithoutEmptyValues(queries) to prevent the fragment from being encoded (i.e. turning the # into a %23), but I just tested your suggestion and it seems to work perfectly, so I'm not sure why tmp.Fragment = "" is there either.

It was mentioned in (#91) that the code used to use ParseRequestURI(), which unlike Parse() assumed that the string provided would not have a fragment. Maybe manually clearing the fragment is a remnant of that? I'm not sure.

Yeah, I think this wasn't working when using url.ParseRequestURI, but right now there are no calls to that method so this should work. Let's merge this in and test on development to see if there's anything wrong with it.

Thanks a lot for your work!