Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PWA service worker, manifest, and assets #296

Closed
wants to merge 2 commits into from

Conversation

m-bers
Copy link

@m-bers m-bers commented Jan 25, 2021

Not a perfect lighthouse score, but Shiori is installable as a PWA, and the app currently works offline for articles that have already loaded.
Screen Shot 2021-01-24 at 8 40 27 PM

Either use localhost or serve (with SSL/TLS) using a reverse proxy like NGINX:

server {
    listen       80;
    listen  [::]:80;
    server_name  shiori.example.com;
    return 301 https://shiori.example.com$request_uri;
}

server {
    listen              443 ssl;
    server_name         shiori.example.com;

    ssl_protocols       TLSv1 TLSv1.1 TLSv1.2;
    ssl_ciphers         HIGH:!aNULL:!MD5;

    ssl_certificate     /etc/letsencrypt/live/example.com/cert.pem;
    ssl_certificate_key /etc/letsencrypt/live/example.com/privkey.pem;

    location / {
        proxy_pass http://shiori:8080;
    }
}

The goal is to eventually make use of the Web Share Target API so it's as easy to save a link to Shiori from Android/iOS as it is with the browser extension.

@m-bers m-bers mentioned this pull request Jan 25, 2021
@hulb hulb mentioned this pull request Dec 5, 2021
pyunramura added a commit to pyunramura/shiori that referenced this pull request Jan 26, 2022
@geekgonecrazy geekgonecrazy mentioned this pull request Feb 18, 2022
@fmartingr
Copy link
Member

Hey @m-bers, thanks a lot for this contribution!

Not sure if you noticed but @geekgonecrazy have continued your work on #325, so I'm going to maintain that PR and mention you there so you can take a more expert look if you don't mind.

@fmartingr fmartingr closed this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants