feat: add option to bypass document readability check #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the bookmark is cached, a test is made and can disqualify a readable document. This option allows the user to bypass this test.
fmartingr
requested changes
Nov 4, 2022
There was a problem hiding this comment.
Hey @Acelya-9028, thanks for the submission! I will take a look at go-shiori/go-readability#26 as well, though I think I haven't experienced this.
This looks good to me, the only thing I would want is some test to check that this works properly, we are lacking a lot in that area so is better if we start adding tests while we work on the changes. Can you take care of that?
fmartingr
reviewed
Nov 4, 2022
|
Hey @fmartingr Ok for tests, I will add this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A check is done to test if a content can be cached but this test may disqualify a readable document so an option is needed to allow users to bypass this test and force bookmarks processing.
Try to fix go-shiori/go-readability#26