Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate bookmark static pages to new http server #775

Merged
merged 27 commits into from
Dec 28, 2023

Merge remote-tracking branch 'origin/master' into feat/bookmark-http-new

15c19df
Select commit
Failed to load commit list.
Merged

refactor: migrate bookmark static pages to new http server #775

Merge remote-tracking branch 'origin/master' into feat/bookmark-http-new
15c19df
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Dec 27, 2023 in 1s

24.99% (+2.92%) compared to fe6a306

View this Pull Request on Codecov

24.99% (+2.92%) compared to fe6a306

Details

Codecov Report

Attention: 120 lines in your changes are missing coverage. Please review.

Comparison is base (fe6a306) 22.06% compared to head (15c19df) 24.99%.

Files Patch % Lines
internal/http/routes/bookmark.go 72.80% 22 Missing and 9 partials ⚠️
internal/domains/storage.go 66.03% 12 Missing and 6 partials ⚠️
internal/domains/archiver.go 0.00% 11 Missing ⚠️
internal/http/routes/api/v1/bookmarks.go 0.00% 10 Missing ⚠️
internal/domains/accounts.go 0.00% 7 Missing ⚠️
internal/cmd/root.go 0.00% 6 Missing ⚠️
internal/domains/bookmarks.go 76.00% 4 Missing and 2 partials ⚠️
internal/webserver/handler-api.go 0.00% 6 Missing ⚠️
internal/cmd/server.go 0.00% 5 Missing ⚠️
internal/http/routes/legacy.go 0.00% 5 Missing ⚠️
... and 9 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
+ Coverage   22.06%   24.99%   +2.92%     
==========================================
  Files          42       45       +3     
  Lines        5696     5534     -162     
==========================================
+ Hits         1257     1383     +126     
+ Misses       4262     3959     -303     
- Partials      177      192      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov