Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require ID field for layers #338

Closed
pnorman opened this issue Feb 26, 2018 · 1 comment
Closed

Don't require ID field for layers #338

pnorman opened this issue Feb 26, 2018 · 1 comment

Comments

@pnorman
Copy link
Contributor

pnorman commented Feb 26, 2018

MVT doesn't require a ID field. Many sources won't have an ID on all layers, and this is the norm on OSM-derived ocean data.
@pnorman pnorman mentioned this issue Feb 26, 2018
Closed
@pnorman
Copy link
Contributor Author

pnorman commented Mar 20, 2018

Fixing this would likely fix #337

@pnorman pnorman changed the title Don't require ID for layers Don't require ID field for layers Mar 20, 2018
@pnorman pnorman mentioned this issue Mar 20, 2018
Open
8 tasks
@pnorman pnorman mentioned this issue Mar 30, 2018
Open
ARolek added a commit that referenced this issue Oct 2, 2018
@ARolek
don't require IDs for mvt features. closes #338
b0aec52 
- removed the unique ID check to match the mvt spec
which says IDs SHOULD be unique but is not a MUST.
- reworked mvt tests to closer align to the new testing
structure and remove the dependency on tbltest package
ARolek added a commit that referenced this issue Oct 2, 2018
@ARolek
don't require IDs for mvt features. closes #338 (#522)
b286279 
* removed the unique ID check to match the mvt spec which says IDs SHOULD be unique but is not a MUST.
* reworked mvt tests to closer align to the new testing structure and remove the dependency on tbltest package.
* removed default id (gid) for postgis provider.
* fixed mvt layer.AddFeature append.
* null id_fieldname handling in postgis provider.
@ARolek ARolek closed this as completed in 84cf61f Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pnorman