Missing water polygon

[pnorman]

With TEGOLA_OPTIONS=DontSimplifyGeo and a self-built 08ddd8f (v0.6.0) I get

In tile 6/10/22 some of the water is missing.

If I zoom in to z7 all the water loads in 7/20/44

The

I checked the DB and the polygons are present in the data, and they are, with fid=1701

Weirdly, it doesn't precisely correspond to what's missing

The layer that produces the problem is

  [[providers.layers]]
  name = "lz_water"
  id_fieldname = "osm_id"
  geometry_fieldname = "way"
  sql = """
  SELECT
      row_number() OVER () AS osm_id,
      ST_AsBinary(way) AS way
    FROM (
      SELECT
          way
        FROM simplified_ocean_polygons
        WHERE way && !BBOX!
      UNION ALL
      SELECT
          way
        FROM planet_osm_polygon
        WHERE way && !BBOX!
          AND (waterway = 'riverbank'
            OR landuse = 'reservoir'
            OR "natural" = 'water')
          AND way_area > pixel_size(9)*4 -- working around tegola #343
    ) _
  """

...

[[maps.layers]]
name = "water"
provider_layer = "osm2pgsql.lz_water"
min_zoom = 6
max_zoom = 9

row_number() OVER () guarantees that this isn't #337, but a different bug.

To isolate it I tried some SQL

create table ocean_test as select * from simplified_ocean_polygons where fid=1701;

And changed the layer SQL to

SELECT
      row_number() OVER () AS osm_id,
      ST_AsBinary(way) AS way
    FROM (
      SELECT
          way
        FROM ocean_test
        -- WHERE way && !BBOX!-- tegola requires !BBOX! in the query, so give it one
    ) _

Hiding tile bounds to get a better view, I have

I highlighted some areas in the z6 tile

These are either interior rings (i.e. islands) like the top one or bays, like the bottom one, reproduced below

I checked and the geometry is both ST_IsValid and ST_IsSimple.

[gdey]

Paul,
Thanks for the report. This is an issue with MakeValid function.

I will look into this after I'm done with the current issue I'm working on.

[gdey]

@pnorman I would like to recreate this on my laptop so that I can figure out what is going wrong with the makevalid function. What data set are you using?

Thank you,

Gautam.

[pnorman]

simplified_ocean_polygons which is http://data.openstreetmapdata.com/simplified-water-polygons-complete-3857.zip with a last modified of Mon, 26 Feb 2018 08:30:25 GMT

I've uploaded the result of \copy ocean_test to ocean_test.csv which you can load in

ocean_test.txt

[gdey]

@pnorman just wanted to let you know I did start working on this, but I started having issues with my laptop, which Apple then took; so it will be around a week before I can get back to this.

[pnorman]

I've done a check of my tracked bugs, and this bug is no longer present in the 0.9.x branch.