Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge should preserve zero value in dest #34

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

42atomys
Copy link
Member

@42atomys 42atomys commented May 15, 2024

Description

Backport fix of sprig into sprout, initially provided by @huww98

Fixes Masterminds#255 Masterminds#399

Checklist

  • I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.
  • This change requires a change to the documentation on the website.

Backport fix of sprig into sprout, initially provided by @huww98

Co-Authored-By: 胡玮文 <huww98@outlook.com>
@42atomys 42atomys self-assigned this May 15, 2024
@42atomys 42atomys added type/bug 🔥 Something isn't working priority/medium 🟨 Priority 3 - Not blocking but should be fixed soon labels May 15, 2024
@42atomys 42atomys added this to the v1.0 milestone May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
maps_functions.go 96.0% <0.0%> (ø)

@42atomys 42atomys merged commit ec86e0b into main May 15, 2024
13 of 14 checks passed
@42atomys 42atomys deleted the fix/sprig-issue-255 branch May 15, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/medium 🟨 Priority 3 - Not blocking but should be fixed soon type/bug 🔥 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merging with zero 0 does not work
1 participant